Skip to content

allow concatenating "hybrid" (sparse/dense) tensors along their dense dimensions #13761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
umanwizard wants to merge 7 commits into from
Closed

allow concatenating "hybrid" (sparse/dense) tensors along their dense dimensions #13761

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8696dd2
allow concatenating "hybrid" (sparse/dense) tensors along their dense…
Nov 9, 2018
5c9ab9b
remove mistaken addition
Nov 9, 2018
d546d90
cat indices along dim 1 instead of transposing
Nov 9, 2018
434c7fb
oops, forgot to rename a variable correctly. fix broken tests in PR
Nov 9, 2018
cb13769
requested changes
Nov 14, 2018
7d5a525
nits
Nov 21, 2018
62e1322
fix lint errors
Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cat indices along dim 1 instead of transposing
  • Loading branch information
Brennan Vincent committed Nov 21, 2018
commit d546d901b8e10b0270a9571275e6a331053cda40
4 changes: 2 additions & 2 deletions aten/src/ATen/native/TensorShape.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,11 @@ static Tensor cat_sparse(TensorList tensors, int64_t dim) {
zeros_sizes[values_dim] = total_size - cumulative_size;
auto z2 = native::zeros(sizes, t._values().options());
vals_pieces.push_back(native::cat({z1, t._values(), z2}, values_dim));
idxs_pieces.push_back(t._indices().t());
idxs_pieces.push_back(t._indices());
}
auto sizes_copy = sizes.vec();
sizes_copy[wrapped] = total_size;
return native::sparse_coo_tensor(native::cat(idxs_pieces).t(), native::cat(vals_pieces), sizes_copy, tensors[0].options());
return native::sparse_coo_tensor(native::cat(idxs_pieces, 1), native::cat(vals_pieces), sizes_copy, tensors[0].options());

This comment was marked as off-topic.

Sign in to view

}
}

Expand Down