[PT2][Optimus] Skip meta update on symblic shape #134975
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D62115015 |
Summary: Pull Request resolved: pytorch#134975 We noticed that there will be runtime error to do the dim broadcast when the meta example value has symbolic shape, thus we skip it. Test Plan: ``` buck2 run mode/opt //caffe2/benchmarks/dynamo/fb:torchbench_run_ads_dhen_5x_training -- -m ads_dhen_5x -t training ``` P1559019921 ``` buck2 run mode/opt //caffe2/benchmarks/dynamo/fb:torchbench_run_ads_cmf_10x_training -- -m ads_cmf_10x -t training ``` P1564162689 Differential Revision: D62115015
|
This pull request was exported from Phabricator. Differential Revision: D62115015 |
mengluy0125
force-pushed
the
export-D62115015
branch
from
2055e29 to
9ebd3d4
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -i |
|
@pytorchbot merge -f "Merged internally, all failures seem to be unrelated dataloader issues" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: We noticed that there will be runtime error to do the dim broadcast when the meta example value has symbolic shape, thus we skip it. Test Plan: ``` buck2 run mode/opt //caffe2/benchmarks/dynamo/fb:torchbench_run_ads_dhen_5x_training -- -m ads_dhen_5x -t training ``` P1559019921 Differential Revision: D62115015 Pull Request resolved: pytorch#134975 Approved by: https://github.com/xuzhao9
6 participants
Summary: We noticed that there will be runtime error to do the dim broadcast when the meta example value has symbolic shape, thus we skip it.
Test Plan:
P1559019921
Differential Revision: D62115015
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang