Rename elementwise_mean to mean #13419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@pytorchbot retest this please |
li-roy
approved these changes
Oct 31, 2018
Contributor
li-roy
left a comment
li-roy
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I'm okay with this, my only concern is NLLLoss (and maybe some others?), which does some sort of weighted average. SizeAverage was never a good name for it, but other ones such as "Normalize" might also not be that good.
Collaborator
Author
|
@li-roy How about just |
Contributor
|
Yeah, I like that |
ssnl
changed the title
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ssnl is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Author
|
This is BC breaking in C++ API (since I removed Reduction::ElementwiseMean) so cc @goldsborough |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 1, 2018
Summary: Closes #12459 Pull Request resolved: pytorch/pytorch#13419 Differential Revision: D12883299 Pulled By: SsnL fbshipit-source-id: 8b4512ff73b66fdc674412904dbb3bf497ba70a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12459