Skip to content

Bug fixes for disabling 0/1 specialization on plain int #129961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 2 commits into from
Closed

Bug fixes for disabling 0/1 specialization on plain int #129961

ezyang wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 2, 2024 •
edited
Loading

@ezyang
Update
6f0953d 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Jul 2, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129961

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51f1787 with merge base 78cda9a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang ezyang changed the title Bug fixes for disabling 0/1 specialization Bug fixes for disabling 0/1 specialization on plain int Jul 2, 2024
@ezyang ezyang requested a review from lezcano July 2, 2024 14:49
@ezyang ezyang added the topic: not user facing topic category label Jul 2, 2024
@ezyang
Copy link
Contributor Author

ezyang commented Jul 2, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 2, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 2, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD albanD removed their request for review July 2, 2024 15:02
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 2, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@ezyang
Update
51f1787 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Jul 2, 2024
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Jul 2, 2024

@pytorchbot merge -f "unlikely to affect rocm"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 2, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ezyang/2818/head branch August 2, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @lezcano