[custom ops] add default value support for device types #129792

yushangdi · 2024-06-28T22:15:53Z

I think the first case in Issue #129371 is already supported in the current code? Since it takes care of string default values. This PR adds support for device type default values.

pytorch-bot · 2024-06-28T22:15:56Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129792

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 8b8b299 with merge base 9fb2dec ():

NEW FAILURE - The following job has failed:

trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh)
dynamo/test_exc.py::ExcTests::test_trigger_on_error

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Lint / workflow-checks / linux-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

khushi-411 · 2024-07-01T04:38:57Z

Hi @yushangdi! Your PR looks great, but I already have PR #129469 before this PR. I want to work on that and solve the issue. Can I continue working on it? Also, happy to know if there's any other issue I could work on. Thank you

test/test_custom_ops.py

yushangdi · 2024-07-01T20:39:03Z

@pytorchbot merge

pytorchmergebot · 2024-07-01T20:40:39Z

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

yushangdi · 2024-07-01T20:42:37Z

@pytorchbot rebase

pytorchmergebot · 2024-07-01T20:44:01Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-07-01T20:44:04Z

Successfully rebased default_device_types onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout default_device_types && git pull --rebase)

yushangdi · 2024-07-01T20:44:32Z

@pytorchbot merge

pytorchmergebot · 2024-07-01T20:46:05Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-01T20:56:31Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cuda11.8-py3 / build

Details for Dev Infra team

Raised by workflow job

yushangdi · 2024-07-02T16:17:11Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-02T16:18:45Z

Merge started

Your change will be merged while ignoring the following 6 checks: Lint / workflow-checks / linux-job, Lint / lintrunner-clang / linux-job, linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build, trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13), trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14), linux-binary-libtorch-cxx11-abi / libtorch-cpu-shared-with-deps-cxx11-abi-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-07-02T16:24:00Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

yushangdi · 2024-07-02T16:25:41Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-02T16:27:48Z

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

yushangdi · 2024-07-02T20:48:32Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-02T20:48:51Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2024-07-02T20:50:29Z

Merge started

Your change will be merged while ignoring the following 1 checks: Lint / workflow-checks / linux-job

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

yushangdi · 2024-07-02T23:29:02Z

@pytorchbot merge -f

pytorch-bot · 2024-07-02T23:29:05Z

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Try @pytorchbot --help for more info.

yushangdi · 2024-07-02T23:29:37Z

@pytorchbot merge -f "failures unrelated"

pytorchmergebot · 2024-07-02T23:29:56Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2024-07-02T23:31:21Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

yushangdi marked this pull request as ready for review June 28, 2024 22:22

yushangdi force-pushed the default_device_types branch from f6db814 to 62422e9 Compare June 28, 2024 22:28

yushangdi added module: custom-operators custom operators, custom ops, custom-operators, custom-ops release notes: composability release notes category labels Jun 28, 2024

yushangdi requested review from zou3519 and removed request for zou3519 June 28, 2024 22:40

yushangdi marked this pull request as draft June 28, 2024 22:47

yushangdi requested a review from zou3519 June 28, 2024 22:57

yushangdi marked this pull request as ready for review June 28, 2024 22:57

zou3519 reviewed Jul 1, 2024

View reviewed changes

test/test_custom_ops.py Outdated Show resolved Hide resolved

yushangdi requested a review from zou3519 July 1, 2024 20:30

zou3519 approved these changes Jul 1, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 1, 2024

pytorchmergebot added the merging label Jul 1, 2024

pytorchmergebot removed the merging label Jul 1, 2024

pytorchmergebot force-pushed the default_device_types branch from f5e33c7 to c342d8e Compare July 1, 2024 20:44

pytorchmergebot added the merging label Jul 1, 2024

pytorchmergebot removed the merging label Jul 1, 2024

khushi-411 mentioned this pull request Jul 2, 2024

[custom_op] support default device types #129469

Closed

pytorchmergebot added the merging label Jul 2, 2024

yushangdi added 8 commits July 2, 2024 09:22

merge

a4b79d2

add string device type test case

794bffd

add test case

36a6ecc

add testing default._schema.arguments

30c6c8b

add enum values to test

deda62a

lint clean up

d96c70d

lint

dcd72ee

lint

8b8b299

yushangdi force-pushed the default_device_types branch from ebed1c1 to 8b8b299 Compare July 2, 2024 16:23

pytorchmergebot removed the merging label Jul 2, 2024

pytorchmergebot added the merging label Jul 2, 2024

pytorchmergebot closed this in aa0352c Jul 2, 2024

pytorchmergebot added Merged and removed merging labels Jul 2, 2024

yushangdi deleted the default_device_types branch July 2, 2024 23:33

[custom ops] add default value support for device types #129792

[custom ops] add default value support for device types #129792

Uh oh!

Conversation

yushangdi commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129792

❌ 1 New Failure, 1 Unrelated Failure

Uh oh!

khushi-411 commented Jul 1, 2024

Uh oh!

Uh oh!

yushangdi commented Jul 1, 2024

Uh oh!

pytorchmergebot commented Jul 1, 2024

Merge failed

Uh oh!

yushangdi commented Jul 1, 2024

Uh oh!

pytorchmergebot commented Jul 1, 2024

Uh oh!

pytorchmergebot commented Jul 1, 2024

Uh oh!

yushangdi commented Jul 1, 2024

Uh oh!

pytorchmergebot commented Jul 1, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 1, 2024

Merge failed

Uh oh!

yushangdi commented Jul 2, 2024

Uh oh!

pytorchmergebot commented Jul 2, 2024

Merge started

Uh oh!

pytorchmergebot commented Jul 2, 2024

Merge failed

Uh oh!

yushangdi commented Jul 2, 2024

Uh oh!

pytorchmergebot commented Jul 2, 2024

Merge started

Uh oh!

yushangdi commented Jul 2, 2024

Uh oh!

pytorchmergebot commented Jul 2, 2024

Uh oh!

pytorchmergebot commented Jul 2, 2024

Merge started

Uh oh!

yushangdi commented Jul 2, 2024

Uh oh!

pytorch-bot bot commented Jul 2, 2024

Uh oh!

yushangdi commented Jul 2, 2024

Uh oh!

pytorchmergebot commented Jul 2, 2024

Uh oh!

pytorchmergebot commented Jul 2, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yushangdi commented Jun 28, 2024 •

edited

Loading

pytorch-bot bot commented Jun 28, 2024 •

edited

Loading