ArgumentStash for int64_t arguments #12939
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesr66a
requested review from
Yangqing,
anderspapitto,
bddppq,
dzhulgakov,
ezyang,
houseroad and
smessmer
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bddppq
approved these changes
Oct 22, 2018
Collaborator
Author
|
@apaszke does this look OK? |
apaszke
reviewed
Oct 25, 2018
Contributor
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
Generally looks ok, but the code is structured in a very weird way
torch/csrc/jit/tracer.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/tracing_state.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/jit/tracer.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jamesr66a
force-pushed
the
argstash_int
branch
from
48c8559 to
a467241
Compare
apaszke
approved these changes
Oct 28, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2019
Summary:
Scalars are being traced as constants.
This PR is to fix this issue.
The ONNX Graph for Test_Full_op() before and after this change:
def Test_Full_op():
class Test_Full(nn.Module):
def forward(self, x):
return torch.full((3, 4), x, dtype=torch.long)
model = Test_Full()
x = torch.tensor(12)
output = model(x)
Before this change:
graph(%input1 : Long()):
%output1 : Float(3, 4) = onnx::Constant[value=<Tensor>]
return (%output1)
After this change:
graph(%input1 : Long()):
%1 : int[] = onnx::Constant[value= 3 4 [ Variable[CPULongType]{2} ]]
%2 : Tensor = onnx::ConstantOfShape[value={0}]
%output1 : Float(3, 4) = onnx::Add(%2, %input1)
return (%output1)
Similar PR : #12939
Pull Request resolved: #21931
Reviewed By: zrphercule
Differential Revision: D15950066
Pulled By: houseroad
fbshipit-source-id: 3470665d88fa34faa600940ef16b069a06002cd5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12906. #12580 is still open because the schema is marked as
traceable=falsein the arg parser constructor, I think.