Skip to content

Fix license metadata in setup.py #129219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vizmo wants to merge 1 commit into from
Closed

Fix license metadata in setup.py #129219

vizmo wants to merge 1 commit into from

Conversation

@vizmo
Copy link
Contributor

@vizmo vizmo commented Jun 21, 2024

Package metadata in setup.py lists license as BSD-3 which is not a valid SPDX id. The correct id would be BSD-3-Clause.

Specifying an SPDX id is beneficial to license compliance scanning.

Taking up #129123 from my personal account.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129219

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (26 Unrelated Failures)

As of commit df91bd7 with merge base c140fa1 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 21, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vizmo / name: Moritz Marseu (df91bd7)

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 21, 2024
@mmarseu mmarseu mentioned this pull request Jun 21, 2024
Closed
malfet
malfet approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it just fixes the typo to match license ID from a list: https://spdx.org/licenses/

@malfet
Copy link
Contributor

malfet commented Jun 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 24, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 24, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 24, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 23, 2024
@kit1980
Copy link
Contributor

kit1980 commented Sep 3, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 3, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 3, 2024

Successfully rebased fix-license-id onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-license-id && git pull --rebase)

@kit1980
Copy link
Contributor

kit1980 commented Sep 4, 2024

@pytorchbot merge -f "Small string change"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@vizmo @Chao1Han
Fix license metadata in setup.py (pytorch#129219)
fb9064a 
Package metadata in setup.py lists license as BSD-3 which is not a valid SPDX id. The correct id would be BSD-3-Clause.

Specifying an SPDX id is beneficial to license compliance scanning.

*Taking up pytorch#129123 from my personal account.*
Pull Request resolved: pytorch#129219
Approved by: https://github.com/malfet, https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vizmo @malfet @pytorchmergebot @kit1980 @pytorchbot