[BE]: Update mypy to 1.10.0 #127717

Skylion007 · 2024-06-02T17:39:54Z

Updates mypy to the latest and greatest.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k

pytorch-bot · 2024-06-02T17:39:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127717

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6b316ed with merge base d0c0892 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

docker-builds / docker-build (pytorch-linux-jammy-aarch64-py3.10-gcc11, linux.arm64.2xlarge) (gh) (matched linux rule in flaky-rules.json)
E: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/jammy-security/main/binary-arm64/Packages.gz File has unexpected size (1598712 != 1600283). Mirror sync in progress? [IP: 91.189.91.38 80]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Skylion007 · 2024-06-02T20:00:02Z

@pytorchbot merge

pytorchmergebot · 2024-06-02T20:02:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-06-02T20:46:04Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Skylion007 · 2024-06-02T21:05:12Z

@pytorchbot merge -f "It's just linter changes"

pytorchmergebot · 2024-06-02T21:07:05Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

huydhn · 2024-06-03T02:51:04Z

@pytorchbot revert -m 'I am not sure why but the failures look legit and they are showing up in trunk https://hud.pytorch.org/pytorch/pytorch/commit/30213ab0a7b27277e76ea9dd707ce629a63d91ee' -c ignoredsignal

pytorchmergebot · 2024-06-03T02:52:42Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit 30213ab. Reverted #127717 on behalf of https://github.com/huydhn due to I am not sure why but the failures look legit and they are showing up in trunk https://hud.pytorch.org/pytorch/pytorch/commit/30213ab0a7b27277e76ea9dd707ce629a63d91ee ([comment](#127717 (comment)))

pytorchmergebot · 2024-06-03T02:52:50Z

@Skylion007 your PR has been successfully reverted.

pytorchmergebot · 2024-06-07T15:46:37Z

Successfully rebased skylion007/update-mypy-1-10-0-2024-06-02 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skylion007/update-mypy-1-10-0-2024-06-02 && git pull --rebase)

pytorchmergebot · 2024-06-07T15:47:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-06-07T16:09:33Z

Merge failed

Reason: 1 jobs have failed, first few of them are: docker-builds / docker-build (linux.12xlarge, pytorch-linux-focal-py3.8-clang10)

Details for Dev Infra team

Raised by workflow job

Skylion007 · 2024-06-10T18:12:19Z

@pytorchbot merge -r

pytorchmergebot · 2024-06-10T18:13:55Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-06-10T18:13:58Z

Successfully rebased skylion007/update-mypy-1-10-0-2024-06-02 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skylion007/update-mypy-1-10-0-2024-06-02 && git pull --rebase)

pytorchmergebot · 2024-06-10T18:15:11Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-06-10T18:25:57Z

Merge failed

Reason: 1 jobs have failed, first few of them are: docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-xpu-2024.0-py3)

Details for Dev Infra team

Raised by workflow job

Skylion007 · 2024-06-13T13:34:35Z

@pytorchbot merge -r

pytorchmergebot · 2024-06-13T13:36:33Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-06-13T13:36:35Z

Successfully rebased skylion007/update-mypy-1-10-0-2024-06-02 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skylion007/update-mypy-1-10-0-2024-06-02 && git pull --rebase)

pytorchmergebot · 2024-06-13T13:37:46Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Updates mypy to the latest and greatest. Pull Request resolved: pytorch#127717 Approved by: https://github.com/ezyang

awgu · 2024-06-17T20:12:14Z

torch/distributed/_composable/fsdp/fully_shard.py

+    setattr(
+        module,
+        method_name,
+        wrapped_method.__get__(module, type(module)),  # type:ignore[attr-defined]


@Skylion007 Do you know why __get__ is not always defined?

pytorch-bot bot added the topic: not user facing topic category label Jun 2, 2024

Skylion007 force-pushed the skylion007/update-mypy-1-10-0-2024-06-02 branch from 93f6ca3 to 7ac9402 Compare June 2, 2024 17:40

pytorchbot added the open source label Jun 2, 2024

pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: quantization release notes category labels Jun 2, 2024

Skylion007 requested review from albanD, ezyang and malfet June 2, 2024 19:44

Skylion007 marked this pull request as ready for review June 2, 2024 19:44

Skylion007 requested a review from jeffdaily as a code owner June 2, 2024 19:44

ezyang approved these changes Jun 2, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 2, 2024

pytorchmergebot added the merging label Jun 2, 2024

pytorchmergebot removed the merging label Jun 2, 2024

pytorchmergebot added the merging label Jun 2, 2024

pytorchmergebot closed this in 30213ab Jun 2, 2024

pytorchmergebot added Merged and removed merging labels Jun 2, 2024

pytorchmergebot added the Reverted label Jun 3, 2024

pytorchmergebot force-pushed the skylion007/update-mypy-1-10-0-2024-06-02 branch from 96d5590 to c546687 Compare June 7, 2024 15:46

pytorchmergebot added the merging label Jun 7, 2024

pytorchmergebot removed the merging label Jun 7, 2024

pytorchmergebot force-pushed the skylion007/update-mypy-1-10-0-2024-06-02 branch from c546687 to 41db1e5 Compare June 10, 2024 18:13

pytorchmergebot added the merging label Jun 10, 2024

pytorchmergebot removed the merging label Jun 10, 2024

Skylion007 added 4 commits June 13, 2024 13:36

[BE]: Update mypy to 1.10.0

0822734

Add type: ignore

c876119

Fix typo

27ad367

Fix argtype

6b316ed

pytorchmergebot force-pushed the skylion007/update-mypy-1-10-0-2024-06-02 branch from 41db1e5 to 6b316ed Compare June 13, 2024 13:36

pytorchmergebot added the merging label Jun 13, 2024

pytorchmergebot closed this in 93a14ab Jun 13, 2024

pytorchmergebot removed the merging label Jun 13, 2024

TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024

[BE]: Update mypy to 1.10.0 (pytorch#127717)

b0d0e82

Updates mypy to the latest and greatest. Pull Request resolved: pytorch#127717 Approved by: https://github.com/ezyang

ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024

[BE]: Update mypy to 1.10.0 (pytorch#127717)

29af2e4

Updates mypy to the latest and greatest. Pull Request resolved: pytorch#127717 Approved by: https://github.com/ezyang

awgu reviewed Jun 17, 2024

View reviewed changes

[BE]: Update mypy to 1.10.0 #127717

[BE]: Update mypy to 1.10.0 #127717

Uh oh!

Conversation

Skylion007 commented Jun 2, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127717

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Skylion007 commented Jun 2, 2024

Uh oh!

pytorchmergebot commented Jun 2, 2024

Merge started

Uh oh!

pytorchmergebot commented Jun 2, 2024

Merge failed

Uh oh!

Skylion007 commented Jun 2, 2024

Uh oh!

pytorchmergebot commented Jun 2, 2024

Merge started

Uh oh!

huydhn commented Jun 3, 2024

Uh oh!

pytorchmergebot commented Jun 3, 2024

Uh oh!

pytorchmergebot commented Jun 3, 2024

Uh oh!

pytorchmergebot commented Jun 7, 2024

Uh oh!

pytorchmergebot commented Jun 7, 2024

Merge started

Uh oh!

pytorchmergebot commented Jun 7, 2024

Merge failed

Uh oh!

Skylion007 commented Jun 10, 2024

Uh oh!

pytorchmergebot commented Jun 10, 2024

Uh oh!

pytorchmergebot commented Jun 10, 2024

Uh oh!

pytorchmergebot commented Jun 10, 2024

Merge started

Uh oh!

pytorchmergebot commented Jun 10, 2024

Merge failed

Uh oh!

Skylion007 commented Jun 13, 2024

Uh oh!

pytorchmergebot commented Jun 13, 2024

Uh oh!

pytorchmergebot commented Jun 13, 2024

Uh oh!

pytorchmergebot commented Jun 13, 2024

Merge started

Uh oh!

awgu Jun 17, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Skylion007 commented Jun 2, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jun 2, 2024 •

edited

Loading