Skip to content

Conversation

@chuanqi129
Copy link
Collaborator

@chuanqi129 chuanqi129 commented May 31, 2024

Due to the xpu ci test has been enabled td by default, a lot of test cases (75%) have been skipped in CI tests. It caused some ci failures escaped from the ci tests, for example issue #127539. This PR depends on PR #127595 landed. Link to #114850

@chuanqi129 chuanqi129 requested a review from a team as a code owner May 31, 2024 09:41
@pytorch-bot
Copy link

pytorch-bot bot commented May 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127611

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ef1ba0a with merge base 16578e8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 31, 2024
@chuanqi129 chuanqi129 added the ciflow/xpu Run XPU CI tasks label May 31, 2024
@etaf
Copy link
Collaborator

etaf commented May 31, 2024

@chuanqi129 To pass all re-enabled XPU test cases, this PR need to land after the PR: #127629

@seemethere
Copy link
Member

@clee2000 can you take a look at this

@etaf
Copy link
Collaborator

etaf commented Jun 2, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xpu_td_disable onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xpu_td_disable && git pull --rebase)

@chuanqi129
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 4, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

petrex pushed a commit to petrex/pytorch that referenced this pull request Jun 5, 2024
Due to the xpu ci test has been enabled td by default, a lot of test cases (75%) have been skipped in CI tests. It caused some ci failures escaped from the ci tests, for example issue pytorch#127539. This PR depends on PR pytorch#127595 landed.
Pull Request resolved: pytorch#127611
Approved by: https://github.com/etaf, https://github.com/atalman
guangyey added a commit that referenced this pull request Jun 11, 2024
# Motivation
Before #127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by #127741.

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jun 13, 2024
# Motivation
Before #127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by #127741.

Pull Request resolved: #128383
Approved by: https://github.com/EikanWang
pytorchbot pushed a commit that referenced this pull request Jun 13, 2024
# Motivation
Before #127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by #127741.

Pull Request resolved: #128383
Approved by: https://github.com/EikanWang

(cherry picked from commit 88974fe)
pytorch-bot bot pushed a commit that referenced this pull request Jun 13, 2024
# Motivation
Before #127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by #127741.

Pull Request resolved: #128383
Approved by: https://github.com/EikanWang

(cherry picked from commit 88974fe)
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
# Motivation
Before pytorch#127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by pytorch#127741.

Pull Request resolved: pytorch#128383
Approved by: https://github.com/EikanWang
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
# Motivation
Before pytorch#127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by pytorch#127741.

Pull Request resolved: pytorch#128383
Approved by: https://github.com/EikanWang
atalman pushed a commit that referenced this pull request Jun 19, 2024
# Motivation
Before #127611 merged, the xpu-specific UT `test/test_xpu.py` was skipped temporarily. This PR aims to fix the UT bug introduced by #127741.

Pull Request resolved: #128383
Approved by: https://github.com/EikanWang

(cherry picked from commit 88974fe)

Co-authored-by: Yu, Guangye <guangye.yu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants