Skip to content

Conversation

@greed2411
Copy link
Contributor

@greed2411 greed2411 commented Oct 17, 2018

Fixes #12251

In the docs the actual key word argument was supposed to be tensors but instead it is given as seq for doing torch.cat operation.

@zou3519 can you review this code? I don't have access to request for code reviews.

@ezyang ezyang requested a review from zou3519 October 17, 2018 03:11
@ezyang
Copy link
Contributor

ezyang commented Oct 17, 2018

Waiting for tests.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@greed2411
Copy link
Contributor Author

@ezyang all checks passed. Thought I should let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs list incorrect parameter name for torch.cat

3 participants