Don't segfault on Tensor.__delitem__ #12726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping protocol stipulates that when __delitem__ is called, this is passed to "__setitem__" (well, the same function in the C extension interface) with NULL data. https://docs.python.org/3/c-api/typeobj.html#c.PyMappingMethods.mp_ass_subscript PyTorch master crashes in this situation, with the patch, it does not anymore.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
colesbury has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping protocol stipulates that when
__delitem__is called, this is passed to__setitem__(well, the same function in the C extension interface) with NULL data.PyTorch master crashes in this situation, with this patch, it does not anymore.
Test code (careful, sefaults your interpreter):