fix masked_fill_ bug on non-contiguous tensor #12594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingfeima
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Collaborator
Author
|
@ezyang hi, the circleci related fail doesn't see to be related to the PR. Please take a look. |
Contributor
|
Can you add that test to the test suite, in this patch? |
colesbury
reviewed
Oct 12, 2018
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
Oct 15, 2018
soumith
force-pushed
the
fix_masked_fill
branch
from
3e3022d to
50861c9
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 15, 2018
Summary: bug fix on #12230 , the following script pass after the fix. ```python x = torch.randn(2, 2, 2) x = x.permute((2, 0, 1)) y = x.clone() y.masked_fill_(y > 0, 1) x.masked_fill_(x > 0, 1) print((x == y).all()) ``` Pull Request resolved: pytorch/pytorch#12594 Differential Revision: D10377088 Pulled By: soumith fbshipit-source-id: 88feabe1459d325bfdf9a860412ddbd28686a28b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix on #12230 , the following script pass after the fix.