torch.finfo and torch.iinfo to mimic the numpy equivalent #12472
Conversation
benoitsteiner
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
benoitsteiner has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Thanks for adding these functions.
The torch.finfo and torch.iinfo probably deserve some documentation. You should be able to add the docstrings in torch/_torch_docs.py and reference them in docs/source/torch.rst.
|
@benoitsteiner Thanks a lot! Is it possible to set the default parameter of |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
benoitsteiner has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
benoitsteiner has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
benoitsteiner has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Looks good.
The latest version of the PR includes formatting changes to other files (torch/csrc/Module.cpp). I would prefer not including those as part of this PR.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
benoitsteiner has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This pull request intends to provide the functionality requested in pytorch/pytorch#10742 by adding a new torch.finfo and torch.iinfo API. Pull Request resolved: pytorch/pytorch#12472 Differential Revision: D10250829 Pulled By: benoitsteiner fbshipit-source-id: eb22ca55d5b0064bef381fa7f1eb75989977df30
7 participants
This pull request intends to provide the functionality requested in #10742 by adding a new torch.finfo and torch.iinfo API.