Skip to content

Conversation

@clee2000
Copy link
Contributor

@clee2000 clee2000 commented Feb 21, 2024

This PR removes and adds some failures and successes that were hidden in the past week (ish).

#119408 (47182a8) accidentally removed environment variables on rerun (see PR body of #120251 for slightly more details).

Enabling testing with dynamo is set using an env var, so if a test failed with dynamo, it would rerun without the dynamo env var set, making it pass on retry. Normally, the flaky test bot would catch this and make an issue for the test, but the CI env var controls whether or not xml test reports get made, and that also got removed on rerun, so the xmls weren't made either.

@clee2000 clee2000 added the keep-going Don't stop on first failure, keep running tests until the end label Feb 21, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120271

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 85db83a with merge base dd6b5e2 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 changed the title Remove some dynamo failures Changes to dynamo_test_failures list Feb 21, 2024
@clee2000 clee2000 added the test-config/dynamo Use this label to run only dynamo tests label Feb 21, 2024
@clee2000 clee2000 changed the title Changes to dynamo_test_failures list Update dynamo_test_failures list Feb 21, 2024
@clee2000 clee2000 marked this pull request as ready for review February 21, 2024 07:11
@clee2000 clee2000 requested review from a team and zou3519 February 21, 2024 07:16
@zou3519 zou3519 added the topic: not user facing topic category label Feb 21, 2024
@zou3519 zou3519 force-pushed the csl/dynamo_failures branch from ef846e8 to fc9ef7b Compare February 21, 2024 14:39
some more

more

update

missed one
@clee2000
Copy link
Contributor Author

@pytorchbot merge -f "its waiting on a docs job"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000 clee2000 deleted the csl/dynamo_failures branch February 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep-going Don't stop on first failure, keep running tests until the end Merged test-config/dynamo Use this label to run only dynamo tests topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants