Skip to content

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Feb 20, 2024

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120232

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit ebacfad with merge base b4b1480 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: fe23bc1
Pull Request resolved: #120232
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 20, 2024
@albanD albanD removed their request for review February 20, 2024 18:25
Microve added a commit to Microve/pytorch that referenced this pull request Feb 20, 2024
Summary: This is an equivalent diff for PR [120232](pytorch#120232). We use this diff for faster landing than importing it from Github, since we need it to fix a QPS regression on CMF v0 model

Test Plan:
Need to comment out here: https://fburl.com/code/1w6vlsrw  
  buck2 test caffe2/test/dynamo:test_dynamo -- -r test_mark_static_inside

Differential Revision: D53953549
@ezyang
Copy link
Contributor Author

ezyang commented Feb 20, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Feb 21, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ezyang/2575/head branch March 23, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants