Skip to content

Add cpp stack traces to our own reruns #119408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albanD wants to merge 4 commits into from
Closed

Add cpp stack traces to our own reruns #119408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b0e8e9
Add cpp stack traces to our own reruns
albanD Feb 7, 2024
856c664
revert extra test failure
albanD Feb 7, 2024
9da3b7b
disable torchinductor_opinfo on macos as it segfault??
albanD Feb 13, 2024
86ea539
Extend to all inductor tests as others segfault as well..
albanD Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/run_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
FILE_SCHEMA,
get_report_path,
IS_CI,
IS_MACOS,
parser as common_parser,
retry_shell,
set_cwd,
Expand Down Expand Up @@ -617,6 +618,16 @@ def print_to_file(s):
else:
sc_command = f"--sc={stepcurrent_key}"
print_to_file("Retrying...")
# Print full c++ stack traces during retries
# Don't do it for macos inductor tests as it makes them
# segfault for some reason
if not (
IS_MACOS
and len(command) >= 2
and command[2].startswith(INDUCTOR_TEST_PREFIX)
):
env = env or {}
env["TORCH_SHOW_CPP_STACKTRACES"] = "1"
print_items = [] # do not continue printing them, massive waste of space

consistent_failures = [x[1:-1] for x in num_failures.keys() if num_failures[x] >= 3]
Expand Down