Remove torch/legacy #11823
Closed
Remove torch/legacy #11823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
|
you need to remove unit tests as well, in |
cpuhrsch
force-pushed
the
export-D9925094
branch
from
18dd1b7 to
6baa5fd
Compare
cpuhrsch
force-pushed
the
export-D9925094
branch
from
6baa5fd to
a2cb66e
Compare
cpuhrsch
force-pushed
the
export-D9925094
branch
from
a2cb66e to
ac7e084
Compare
cpuhrsch
force-pushed
the
export-D9925094
branch
from
ac7e084 to
3663fa7
Compare
Contributor
Author
|
Legacy was used to write the following tests:
Will create issues for new implementations. "TestLuaReader" was deleted (doesn't need a new implementation). |
cpuhrsch
force-pushed
the
export-D9925094
branch
from
3663fa7 to
2029c03
Compare
cpuhrsch
force-pushed
the
export-D9925094
branch
from
2029c03 to
370cbb5
Compare
cpuhrsch
force-pushed
the
export-D9925094
branch
from
370cbb5 to
3433698
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Largely unused and hinders current development Pull Request resolved: pytorch#11823 Differential Revision: D9925094 Pulled By: cpuhrsch fbshipit-source-id: 1f53f8f21da85c16ae32e75fe6f796718e39fc92
cpuhrsch
force-pushed
the
export-D9925094
branch
from
3433698 to
d9ee045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Largely unused and hinders current development
Differential Revision: D9925094