Skip to content

Throw error on indexing a 0 dim tensor #11679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
driazati wants to merge 2 commits into from
Closed

Throw error on indexing a 0 dim tensor #11679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9758726
Throw error on indexing a 0 dim tensor
Sep 13, 2018
769bc80
Fix unit test
Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,14 @@ def test_invalid_index(self):
self.assertRaisesRegex(TypeError, 'slice indices', lambda: x["0":"1"])

def test_zero_dim_index(self):
# We temporarily support indexing a zero-dim tensor as if it were
# a one-dim tensor to better maintain backwards compatibility.
x = torch.tensor(10)
with warnings.catch_warnings(record=True) as w:
self.assertEqual(x, x[0])
self.assertEqual(len(w), 1)
self.assertEqual(x, x.item())

def runner():
print(x[0])
return x[0]

self.assertRaisesRegex(IndexError, 'invalid index', runner)


# The tests below are from NumPy test_indexing.py with some modifications to
Expand Down
8 changes: 3 additions & 5 deletions torch/csrc/autograd/python_variable_indexing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,9 @@ static Variable applySlice(const Variable& self, int64_t dim, PyObject* slice, b

static Variable applySelect(const Variable& self, int64_t dim, int64_t index) {
if (index == 0 && dim == 0 && self.dim() == 0) {
// Deprecated support for indexing 0-dim tensors as if they were 1-dim.
PyErr_WarnEx(PyExc_UserWarning,
"invalid index of a 0-dim tensor. This will be an error in PyTorch 0.5. "
"Use tensor.item() to convert a 0-dim tensor to a Python number", 1);
return at::alias(self);
throw IndexError(
"invalid index of a 0-dim tensor. "
"Use tensor.item() to convert a 0-dim tensor to a Python number");
}
int64_t size = self.size(dim);
if (index < -size || index >= size) {
Expand Down