Throw error on indexing a 0 dim tensor #11679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Following through on warning that indexing 0-dim tensor would be an error in PyTorch 0.5 Test Plan: Reviewers: Subscribers: Tasks: Tags:
driazati
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ezyang
approved these changes
Sep 14, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Wow, we didn't test this at all?
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Contributor
Author
|
Turns out we did, the CI caught it |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
driazati is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@driazati Some internal changes are needed. |
Contributor
Author
|
See D9871555 |
gchanan
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following through on warning that indexing 0-dim tensor would be an
error in PyTorch 0.5 and to use
item()instead