Only involve tensor device in CUDA -> CPU copy, not current device. #11592
Conversation
This also unifies the device usage between the async and sync case. Fixes pytorch#10832.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
test/run_test.py
Outdated
| 'cpp_extensions', | ||
| 'c10d', | ||
| 'cuda', | ||
| 'cuda_primary_ctx.py' |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| self.assertFalse(get_is_primary_context_created(0)) | ||
| self.assertTrue(get_is_primary_context_created(1)) | ||
|
|
||
| # DO NOT ADD ANY OTHER TESTS HERE! ABOVE TEST REQUIRES FRESH PROCESS |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
|
||
| { | ||
| THTensor *selfc = THTensor_(newContiguous)(self); | ||
| int tensorDevice = THCTensor_(getDevice)(state, src); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…#11592) Summary: This also unifies the device usage between the async and sync case. Fixes pytorch/pytorch#10832. Pull Request resolved: pytorch/pytorch#11592 Differential Revision: D9797355 Pulled By: gchanan fbshipit-source-id: e496cd371111cfaf9a6c664167967b395e3d72e9
4 participants
This also unifies the device usage between the async and sync case.
Fixes #10832.