Skip to content

[pytree] support collections.deque type for Python pytree #113256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XuehaiPan wants to merge 15 commits into from
Closed

[pytree] support collections.deque type for Python pytree #113256

XuehaiPan wants to merge 15 commits into from

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Nov 8, 2023 •
edited
Loading

@XuehaiPan XuehaiPan mentioned this pull request Nov 8, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113256

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7104738 with merge base f93ea14 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XuehaiPan XuehaiPan mentioned this pull request Nov 8, 2023
Closed
@XuehaiPan XuehaiPan added the topic: not user facing topic category label Nov 8, 2023
This was referenced Nov 8, 2023
Closed
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Nov 11, 2023
@XuehaiPan
[pytree] support collections.deque type for Python pytree
9dd0a0d 
ghstack-source-id: 0ce3561
Pull Request resolved: pytorch#113256
This was referenced Nov 22, 2023
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Nov 22, 2023
@XuehaiPan
[pytree] support collections.deque type for Python pytree
d1dcdb9 
ghstack-source-id: 54cfb2b
Pull Request resolved: pytorch#113256
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Nov 28, 2023
@XuehaiPan
[pytree] support collections.deque type for Python pytree
7eca34b 
ghstack-source-id: e0075f0
Pull Request resolved: pytorch#113256
@XuehaiPan XuehaiPan mentioned this pull request Nov 30, 2023
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Nov 30, 2023
@XuehaiPan
[pytree] support collections.deque type for Python pytree
9f6a44f 
ghstack-source-id: 753c2d9
Pull Request resolved: pytorch#113256
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Nov 30, 2023
@XuehaiPan
[pytree] support collections.deque type for Python pytree
70be632 
ghstack-source-id: 8f5b207
Pull Request resolved: pytorch#113256
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 30, 2023
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Nov 30, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 30, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 30, 2023

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 70be632b93cd4df8adcdb519239ac2068ba93e3e returned non-zero exit code 1

Auto-merging test/test_pytree.py
CONFLICT (content): Merge conflict in test/test_pytree.py
Auto-merging torch/utils/_pytree.py
CONFLICT (content): Merge conflict in torch/utils/_pytree.py
error: could not apply 70be632b93c... [pytree] support collections.deque type for Python pytree
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Dec 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 1, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/XuehaiPan/12/head branch December 4, 2023 15:29
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@XuehaiPan @dmenig
[pytree] support collections.deque type for Python pytree (pytorch#11…
5d7f20b 
…3256)

Pull Request resolved: pytorch#113256
Approved by: https://github.com/zou3519
ghstack dependencies: pytorch#112485, pytorch#113255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: pytree open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XuehaiPan @pytorchmergebot @zou3519 @pytorchbot