[pytree] support collections.defaultdict type for Python pytree #113255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113255
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4a334a6 with merge base f93ea14 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 8, 2023
…ytree" cc zou3519 [ghstack-poisoned]
…ytree" cc zou3519 [ghstack-poisoned]
…ytree" cc zou3519 [ghstack-poisoned]
…ytree" cc zou3519 [ghstack-poisoned]
…ytree" cc zou3519 [ghstack-poisoned]
This was referenced Nov 8, 2023
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 11, 2023
ghstack-source-id: fdad50f Pull Request resolved: pytorch#113255
…ytree" cc zou3519 [ghstack-poisoned]
This was referenced Nov 22, 2023
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 22, 2023
ghstack-source-id: 28d7680 Pull Request resolved: pytorch#113255
…ytree" cc zou3519 [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 28, 2023
ghstack-source-id: 8f40be9 Pull Request resolved: pytorch#113255
…ytree" cc zou3519 [ghstack-poisoned]
…ytree" cc zou3519 [ghstack-poisoned]
zou3519
reviewed
Nov 30, 2023
| return defaultdict(default_factory, zip(keys, values)) | ||
|
|
||
|
|
||
| def _defaultdict_serialize(context: Context) -> DumpableContext: |
Contributor
There was a problem hiding this comment.
Can you add a test for _defaultdict_serialize/_defaultdict_deserialize?
Collaborator
Author
There was a problem hiding this comment.
I add a serialization test case for defaultdict.
zou3519
reviewed
Nov 30, 2023
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
Needs a test for serializing/deserializing defaultdict, otherwise, LGTM
…ytree" cc zou3519 [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 30, 2023
ghstack-source-id: 4762fc7 Pull Request resolved: pytorch#113255
zou3519
approved these changes
Nov 30, 2023
…ytree" cc zou3519 [ghstack-poisoned]
XuehaiPan
commented
Nov 30, 2023
| def _defaultdict_flatten(d: DefaultDict[Any, Any]) -> Tuple[List[Any], Context]: | ||
| values, dict_context = _dict_flatten(d) | ||
| return values, (d.default_factory, dict_context) | ||
| return values, [d.default_factory, dict_context] |
Collaborator
Author
There was a problem hiding this comment.
Changed the context type from tuple to list. Because json.dumps serializes a tuple to a array, while a array is deserialized to list.
…ytree" cc zou3519 [ghstack-poisoned]
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Nov 30, 2023
ghstack-source-id: 3a58a5c Pull Request resolved: pytorch#113255
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 1, 2023
Pull Request resolved: #113256 Approved by: https://github.com/zou3519 ghstack dependencies: #112485, #113255
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…rch#113255) Pull Request resolved: pytorch#113255 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#112485
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…3256) Pull Request resolved: pytorch#113256 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#112485, pytorch#113255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
none_is_leafandnamespacein C++ pytree #114858cc @zou3519