Skip to content

Conversation

@vishwakftw
Copy link
Contributor

  • Modify torch.autograd.gradcheck to use torch.allclose instead
  • Expose doc strings

Closes #10355

- Modify torch.autograd.gradcheck to use torch.allclose instead
@vishwakftw
Copy link
Contributor Author

Using ATen's allclose makes the gradcheck tests in test_autograd a tad faster than earlier.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@vishwakftw vishwakftw deleted the allclose-doc branch September 2, 2018 16:28
PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
Summary:
- Modify torch.autograd.gradcheck to use torch.allclose instead
- Expose doc strings

Closes pytorch#10355
Pull Request resolved: pytorch#11185

Differential Revision: D9628016

Pulled By: soumith

fbshipit-source-id: 22a30622b9fe52e41b5b3540406137b59d8c5a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing documentation for torch.allclose

4 participants