Refactor expect tests on test_higher_order_ops.py. #110290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR inlines the expecteds strings onto the `assertExpectedInline` calls, so that, when change is needed, we may do that by using the `expectedtest` machinery: setting the environment variable `EXPECTTEST_ACCEPT=1`. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110290
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit df8dbf1 with merge base 428cbd7 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR inlines the expecteds strings onto the `assertExpectedInline` calls, so that, when change is needed, we may do that by using the `expectedtest` machinery: setting the environment variable `EXPECTTEST_ACCEPT=1`. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
zou3519
approved these changes
Sep 29, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 2, 2023
Fix: #109247 This PR flattens `wrap` outputs by inlining `pytree.tree_flatten` function after calling the inner function. Pull Request resolved: #109433 Approved by: https://github.com/zou3519 ghstack dependencies: #110290
Contributor
|
@pytorchbot revert -m "Broke multiple tests and also lint https://github.com/pytorch/pytorch/actions/runs/6384854768/job/17329068768" -c ignoredsignal |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@ysiraichi your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 2, 2023
This reverts commit d9aecae. Reverted #110290 on behalf of https://github.com/kit1980 due to Broke multiple tests and also lint https://github.com/pytorch/pytorch/actions/runs/6384854768/job/17329068768 ([comment](#110290 (comment)))
pytorchmergebot
added a commit
that referenced
this pull request
Oct 2, 2023
This reverts commit 651b198. Reverted #109433 on behalf of https://github.com/kit1980 due to Depends on reverted #110290 ([comment](#109433 (comment)))
Contributor
Actually this one may be OK and the next one in the stack is the problem, but because it was landed as a stack, the CI was run only on the last PR. |
This PR inlines the expecteds strings onto the `assertExpectedInline` calls, so that, when change is needed, we may do that by using the `expectedtest` machinery: setting the environment variable `EXPECTTEST_ACCEPT=1`. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Fix: #109247 This PR flattens `wrap` outputs by inlining `pytree.tree_flatten` function after calling the inner function. Pull Request resolved: #109433 Approved by: https://github.com/zou3519 ghstack dependencies: #110290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
gradwith pytree inputs. #110417autograd.Functionwith multiple return values. #107618wrap. #109433This PR inlines the expecteds strings onto the
assertExpectedInlinecalls, so that, whenchange is needed, we may do that by using the
expectedtestmachinery: setting theenvironment variable
EXPECTTEST_ACCEPT=1.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng