bug-fix in normal_( ) #10846
Closed
bug-fix in normal_( ) #10846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
weiyangfb
commented
Aug 24, 2018
weiyangfb
commented
- fixes Inplace function normal_( ) changing wrong row of tensor #10642
weiyangfb
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
soumith
approved these changes
Aug 24, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ssnl
approved these changes
Aug 24, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 24, 2018
Summary: - fixes #10642 Pull Request resolved: pytorch/pytorch#10846 Differential Revision: D9495014 Pulled By: weiyangfb fbshipit-source-id: 35a9fc349f9f0c21a24141f29c62853ab6a68dae
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: - fixes pytorch#10642 Pull Request resolved: pytorch#10846 Differential Revision: D9495014 Pulled By: weiyangfb fbshipit-source-id: 35a9fc349f9f0c21a24141f29c62853ab6a68dae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.