Skip to content

[Dynamo x FSDP][1/x] Builder support for deque, appendleft #106884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
voznesenskym wants to merge 4 commits into from
Closed

[Dynamo x FSDP][1/x] Builder support for deque, appendleft #106884

voznesenskym wants to merge 4 commits into from

Conversation

@voznesenskym
Copy link
Collaborator

@voznesenskym voznesenskym commented Aug 9, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106884

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit 4025afc:

NEW FAILURE - The following job has failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD removed their request for review August 9, 2023 18:18
This was referenced Aug 9, 2023
Closed
Closed
Closed
Closed
Closed
@voznesenskym voznesenskym changed the title [Dynamo x FSDP][1/x] Builder support for deque [Dynamo x FSDP][1/x] Builder support for deque, appendleft Aug 10, 2023
@voznesenskym
Update on "[Dynamo x FSDP][1/x] Builder support for deque, appendleft"
41dc153 
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
ezyang
ezyang reviewed Aug 10, 2023
View reviewed changes
torch/_dynamo/variables/lists.py
return tx.replace_all(
self,
DequeVariable(
[args[0]] + list(self.items),
Copy link
Contributor

@ezyang ezyang Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should do destructuring similar to as seen in extendleft so that you test that all arguments are actually used.

Copy link
Collaborator Author

@voznesenskym voznesenskym Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you elaborate?

ezyang
ezyang reviewed Aug 10, 2023
View reviewed changes
test/dynamo/test_misc.py

def fn(q):
a = q.pop()
b = q.pop()
Copy link
Contributor

@ezyang ezyang Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like it exercises all of the methods you added

Copy link
Collaborator Author

@voznesenskym voznesenskym Aug 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more test

@voznesenskym
Update on "[Dynamo x FSDP][1/x] Builder support for deque, appendleft"
e51a663 
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
@voznesenskym
Update on "[Dynamo x FSDP][1/x] Builder support for deque, appendleft"
4025afc 
cc penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
@voznesenskym voznesenskym added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Aug 11, 2023
@voznesenskym
Copy link
Collaborator Author

voznesenskym commented Aug 11, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2023

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@voznesenskym
Copy link
Collaborator Author

voznesenskym commented Aug 11, 2023

@pytorchbot merge -f "Flaky ci"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Aug 11, 2023
@voznesenskym @pytorchmergebot
[Dynamo x FSDP][2/x] Small changes to distributed to make it dynamo f…
4266001 
…riendly (#106886)

Pull Request resolved: #106886
Approved by: https://github.com/awgu, https://github.com/wconstab
ghstack dependencies: #106884
voznesenskym added a commit that referenced this pull request Aug 12, 2023
@voznesenskym
[Dynamo x FSDP][1/x] Builder support for deque
69da512 
ghstack-source-id: 0d52cb3
Pull Request resolved: #106884

Appendleft test
voznesenskym added a commit that referenced this pull request Aug 20, 2023
@voznesenskym
[Dynamo x FSDP][1/x] Builder support for deque
1e68baa 
ghstack-source-id: 0d52cb3
Pull Request resolved: #106884

Appendleft test
voznesenskym added a commit that referenced this pull request Oct 2, 2023
@voznesenskym
[Dynamo x FSDP][1/x] Builder support for deque
9545d75 
ghstack-source-id: 0d52cb3
Pull Request resolved: #106884

Appendleft test
voznesenskym added a commit that referenced this pull request Oct 9, 2023
@voznesenskym
[Dynamo x FSDP][1/x] Builder support for deque
a0bee5d 
ghstack-source-id: 0d52cb3
Pull Request resolved: #106884

Appendleft test
voznesenskym added a commit that referenced this pull request Oct 18, 2023
@voznesenskym
[Dynamo x FSDP][1/x] Builder support for deque
b5424d2 
ghstack-source-id: 0d52cb3
Pull Request resolved: #106884

Appendleft test
voznesenskym added a commit that referenced this pull request Oct 24, 2023
@voznesenskym
[Dynamo x FSDP][1/x] Builder support for deque
89488e2 
ghstack-source-id: 0d52cb3
Pull Request resolved: #106884

Appendleft test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@voznesenskym @pytorchmergebot @ezyang