support broadcasting in _kl_categorical_categorical #10533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joh4n
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
|
Could you please add a test in |
Contributor
Author
|
I added a basic test for it |
vishwakftw
reviewed
Aug 15, 2018
test/test_distributions.py
Outdated
| (binomial30, binomial30), | ||
| (binomial_vectorized_count, binomial_vectorized_count), | ||
| (categorical, categorical), | ||
| (Categorical(torch.ones(1, 10)), Categorical(torch.ones(3, 10))), |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
vishwakftw
approved these changes
Aug 15, 2018
Contributor
vishwakftw
left a comment
vishwakftw
left a comment
There was a problem hiding this comment.
LGTM. Thank you for fixing this.
soumith
approved these changes
Aug 15, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support broadcasting in _kl_categorical_categorical
this makes it possible to do: