[HigherOrderOp] Remove `_deprecated_global_ns` from some ops #104105

zou3519 · 2023-06-23T15:05:39Z

Stack from ghstack:

-> [HigherOrderOp] Remove _deprecated_global_ns from some ops #104105

The remaining ops after this PR are:

cond
map
anything that is out of tree.

These are a bit more difficult to remove.

Test Plan:

existing tests

The remaining ops after this PR are: - cond - map - anything that is out of tree. These are a bit more difficult to remove. Test Plan: - existing tests [ghstack-poisoned]

pytorch-bot · 2023-06-23T15:05:41Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104105

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 797281d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

The remaining ops after this PR are: - cond - map - anything that is out of tree. These are a bit more difficult to remove. Test Plan: - existing tests ghstack-source-id: a4d4a77 Pull Request resolved: #104105

zou3519 · 2023-06-26T17:10:33Z

@pytorchbot merge

pytorchmergebot · 2023-06-26T17:12:45Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

zou3519 · 2023-06-27T19:31:52Z

@pytorchbot merge

pytorchmergebot · 2023-06-27T19:33:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-06-27T19:33:38Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team

Raised by workflow job

zou3519 · 2023-06-27T19:43:19Z

@pytorchbot merge -r

pytorchmergebot · 2023-06-27T19:44:57Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-06-27T19:45:02Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/zou3519/683/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/_higher_order_ops/wrap.py
CONFLICT (content): Merge conflict in torch/_higher_order_ops/wrap.py
error: could not apply 245e18dfcd5... [HigherOrderOp] Remove `_deprecated_global_ns` from some ops
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 245e18dfcd5... [HigherOrderOp] Remove `_deprecated_global_ns` from some ops

Raised by https://github.com/pytorch/pytorch/actions/runs/5393956534

The remaining ops after this PR are: - cond - map - anything that is out of tree. These are a bit more difficult to remove. Test Plan: - existing tests [ghstack-poisoned]

zou3519 · 2023-06-28T00:01:19Z

@pytorchbot merge

pytorchmergebot · 2023-06-28T00:03:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: Remove _deprecated_global_ns from cond following pytorch#104105. To do that, we need to change how graph_module generates python_code for "cond" target. Otherwise, it will generate target as "torch.ops.cond", which is invalid after the change. Will import this PR to fix internal tests. cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 Pull Request resolved: pytorch#104380 Reviewed By: zou3519 Differential Revision: D47110919 Pulled By: ydwu4 fbshipit-source-id: e0b8090982cee2c1415abb663bb6308eeb4a52b4

Summary: Remove _deprecated_global_ns from cond following pytorch/pytorch#104105. To do that, we need to change how graph_module generates python_code for "cond" target. Otherwise, it will generate target as "torch.ops.cond", which is invalid after the change. Will import this PR to fix internal tests. cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 X-link: pytorch/pytorch#104380 Reviewed By: zou3519 Differential Revision: D47110919 Pulled By: ydwu4 fbshipit-source-id: eed2f7e0aa6bfc0d0a46f0064630abed872e3d75

Remove _deprecated_global_ns from cond following #104105. We change the module attribute of HigherOrderOperator instances in the constructor from torch.ops to torch.ops.higher_order when self.namespace is "higher_order". For subclasses (e.g. customized higher order operator), we leave their \_\_module\_\_ unchanged. Will import this PR to fix internal tests. Pull Request resolved: #104380 Approved by: https://github.com/zhxchen17, https://github.com/zou3519

[HigherOrderOp] Remove _deprecated_global_ns from some ops

a389d87

The remaining ops after this PR are: - cond - map - anything that is out of tree. These are a bit more difficult to remove. Test Plan: - existing tests [ghstack-poisoned]

zou3519 requested a review from ydwu4 June 23, 2023 15:06

ydwu4 approved these changes Jun 26, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 26, 2023

pytorchmergebot added the merging label Jun 26, 2023

pytorchmergebot removed the merging label Jun 26, 2023

zou3519 added the topic: not user facing topic category label Jun 26, 2023

pytorchmergebot added the merging label Jun 27, 2023

pytorchmergebot removed the merging label Jun 27, 2023

Update on "[HigherOrderOp] Remove _deprecated_global_ns from some ops"

797281d

The remaining ops after this PR are: - cond - map - anything that is out of tree. These are a bit more difficult to remove. Test Plan: - existing tests [ghstack-poisoned]

pytorchmergebot added the merging label Jun 28, 2023

pytorchmergebot added Merged and removed merging labels Jun 28, 2023

pytorchmergebot closed this in 280df5d Jun 28, 2023

ydwu4 mentioned this pull request Jun 28, 2023

[HigherOrderOp] Remove _deprecated_global_ns from cond #104380

Closed

facebook-github-bot deleted the gh/zou3519/683/head branch July 1, 2023 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[HigherOrderOp] Remove `_deprecated_global_ns` from some ops #104105

[HigherOrderOp] Remove `_deprecated_global_ns` from some ops #104105

Uh oh!

zou3519 commented Jun 23, 2023 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jun 23, 2023 •

edited

Loading

Uh oh!

zou3519 commented Jun 26, 2023

Uh oh!

pytorchmergebot commented Jun 26, 2023

Uh oh!

zou3519 commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Uh oh!

zou3519 commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Uh oh!

zou3519 commented Jun 28, 2023

Uh oh!

pytorchmergebot commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[HigherOrderOp] Remove _deprecated_global_ns from some ops #104105

[HigherOrderOp] Remove _deprecated_global_ns from some ops #104105

Uh oh!

Conversation

zou3519 commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104105

✅ No Failures

Uh oh!

zou3519 commented Jun 26, 2023

Uh oh!

pytorchmergebot commented Jun 26, 2023

Merge failed

Uh oh!

zou3519 commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Merge started

Uh oh!

pytorchmergebot commented Jun 27, 2023

Merge failed

Uh oh!

zou3519 commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Uh oh!

pytorchmergebot commented Jun 27, 2023

Uh oh!

zou3519 commented Jun 28, 2023

Uh oh!

pytorchmergebot commented Jun 28, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[HigherOrderOp] Remove `_deprecated_global_ns` from some ops #104105

[HigherOrderOp] Remove `_deprecated_global_ns` from some ops #104105

zou3519 commented Jun 23, 2023 •

edited

Loading

pytorch-bot bot commented Jun 23, 2023 •

edited

Loading