[quant][pt2] Add test for inplace add #102867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

andrewor14 wants to merge 1 commit into pytorch:main from andrewor14:export-D46402378

Contributor

andrewor14 commented Jun 2, 2023 •

edited

Loading

Summary: This was broken after the recent partitioner refactors.

Test Plan: python test/test_quantization.py TestQuantizePT2E.test_qat_inplace_add_relu

Differential Revision: D46402378

andrewor14 requested a review from jerryzh168 as a code owner

June 2, 2023 18:42

pytorch-bot bot added the release notes: quantization label

pytorch-bot bot commented Jun 2, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102867

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d022d6c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jun 2, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

jerryzh168 approved these changes

View reviewed changes

Contributor

jerryzh168 left a comment

thanks, I remember added this in one of my diffs as well

andrewor14 changed the title ~~[quant][pt2] Fix annotation for inplace add~~ [quant][pt2] Add test for inplace add

andrewor14 force-pushed the export-D46402378 branch from 7aa5d03 to 52d4e64 Compare

June 5, 2023 20:17

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

andrewor14 force-pushed the export-D46402378 branch from 52d4e64 to 55dc3c5 Compare

June 5, 2023 20:23

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

andrewor14 force-pushed the export-D46402378 branch from 55dc3c5 to d6a0249 Compare

June 5, 2023 20:30

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

andrewor14 force-pushed the export-D46402378 branch from d6a0249 to 1d66cc0 Compare

June 5, 2023 20:39

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

andrewor14 force-pushed the export-D46402378 branch from 1d66cc0 to a93f686 Compare

June 5, 2023 20:53

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

andrewor14 force-pushed the export-D46402378 branch from a93f686 to 0038ab0 Compare

June 5, 2023 21:12

Contributor

facebook-github-bot commented Jun 5, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

andrewor14 force-pushed the export-D46402378 branch from 0038ab0 to c475b40 Compare

June 6, 2023 16:15

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378


          [quant][pt2] Add test for inplace add (pytorch#102867)

d022d6c

Summary:
Pull Request resolved: pytorch#102867

This was broken after the recent partitioner refactors.

Test Plan: python test/test_quantization.py TestQuantizePT2E.test_qat_inplace_add_relu

Reviewed By: jerryzh168

Differential Revision: D46402378

fbshipit-source-id: f08094a7ef50492dc55cda82a7106520024ec284

andrewor14 force-pushed the export-D46402378 branch from c475b40 to d022d6c Compare

June 6, 2023 16:25

Contributor

facebook-github-bot commented Jun 6, 2023

This pull request was exported from Phabricator. Differential Revision: D46402378

Contributor

facebook-github-bot commented Jun 7, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jun 7, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

2e8d2a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged release notes: quantization