Fixes for Prod and Expand functions #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @ChangYong-Oh for the original implementation.
Closed
soumith
approved these changes
Mar 17, 2017
| return grad_output.mul(self.result).expand_as(input).div(input) | ||
| elif zero_idx.size(0) > 1: | ||
| return grad_output.new(self.input_size).zero_() | ||
| else: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| single_zero_idx = slice_zero_count.eq(1).nonzero() | ||
| for idx in single_zero_idx: | ||
| idx_tuple = tuple(idx.cpu()) | ||
| input_idx_tuple = idx_tuple[:self.dim] + (slice(0, None),) + idx_tuple[self.dim + 1:] |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Nov 5, 2021
* Adds a boolean option to `shift` to disable padding. Shifting without padding only sets values in a range that correspond to the valid range in the input tensor. * Separate read and write predicates for block and grid reductions * For block reductions, it's necessary when reduction axes may not start with zero. For grid reductions, see issue pytorch#1049.
jaglinux
added a commit
to jaglinux/pytorch
that referenced
this pull request
Jul 5, 2022
Increase system memory requirement for TestShapeOpsCUDA.test_flip_large_tensor_cuda Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
jaglinux
added a commit
to jaglinux/pytorch
that referenced
this pull request
Jul 19, 2022
Increase system memory requirement for TestShapeOpsCUDA.test_flip_large_tensor_cuda Signed-off-by: Jagadish Krishnamoorthy <jagdish.krishna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #773, #995, #998.
cc: @ChangYong-Oh @Teaonly