Fix issue #995 #1002
Closed
Fix issue #995 #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There's still a problem with 0 inputs that's fixed in #938. I don't want to merge it right now because it will lead to conflicts with that PR. I'll review it today and see how to solve it. |
fmassa
reviewed
Mar 15, 2017
| if self.dim is None: | ||
| input, = self.saved_tensors | ||
| grad_input = grad_output.new(self.input_size).fill_(self.result) | ||
| grad_input = grad_output.new(self.input_size).fill_(self.result * grad_output[0]) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
Fixed in #1026. Thanks! |
soumith
added a commit
that referenced
this pull request
Apr 12, 2017
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Aug 5, 2021
syed-ahmed
pushed a commit
to syed-ahmed/pytorch
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.