Skip to content

Problems of exposing const char * field in struct ncclConfig_t  #104340

@ehuaa

Description

@ehuaa

🐛 Describe the bug

In #97394 , a user can tune the parameters of ncclConfig_t. While ncclConfig_t has a const char * field called netName
image

when we assign net_name with code below: eg. nccl_options.config.net_name = "IB", this field turned out to be an unreadable code. such as
image
which i supposed it to be IB.
Is the wrong transition between char * and string cause this error, and how can i fix it to assign the net_name correctly, thanks!

Versions

Name: torch
Version: 2.1.0a0+git7cef719

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu

Metadata

Metadata

Assignees

Labels

module: ncclProblems related to nccl supportoncall: distributedAdd this issue/PR to distributed oncall triage queue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions