Revert "[follow-up] Python Attr Serialization (#88913)"

pytorchmergebot · pytorchmergebot · commit f5fbb5001fdf · 2022-12-02T20:14:11.000Z
This reverts commit 086b251. Reverted #88913 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally
diff --git a/test/test_serialization.py b/test/test_serialization.py
@@ -948,7 +948,11 @@ def _test_save_load_attr(t):
 
         t = torch.zeros(3, 3)
         _test_save_load_attr(t)
-        _test_save_load_attr(torch.nn.Parameter(t))
+        # This should start failing once Parameter
+        # supports saving Python Attribute.
+        err_msg = "'Parameter' object has no attribute"
+        with self.assertRaisesRegex(AttributeError, err_msg):
+            _test_save_load_attr(torch.nn.Parameter(t))
 
     def test_weights_only_assert(self):
         class HelloWorld:
diff --git a/torch/_utils.py b/torch/_utils.py
@@ -352,6 +352,8 @@ def _rebuild_parameter(data, requires_grad, backward_hooks):
     return param
 
 
+# TODO(kshitij12345): Support serializing nn.Parameter with Python Attributes.
+# NOTE: We are just defining it here now for future use.
 def _rebuild_parameter_with_state(data, requires_grad, backward_hooks, state):
     param = torch.nn.Parameter(data, requires_grad)
     # NB: This line exists only for backwards compatibility; the
diff --git a/torch/nn/parameter.py b/torch/nn/parameter.py
@@ -60,19 +60,11 @@ def __repr__(self):
         return 'Parameter containing:\n' + super(Parameter, self).__repr__()
 
     def __reduce_ex__(self, proto):
-        state = torch._utils._get_obj_state(self)
-
+        # TODO(kshitij12345): Support saving Python Attribute
         # See Note [Don't serialize hooks]
-        hooks = OrderedDict()
-        if not state:
-            return (
-                torch._utils._rebuild_parameter,
-                (self.data, self.requires_grad, hooks)
-            )
-
         return (
-            torch._utils._rebuild_parameter_with_state,
-            (self.data, self.requires_grad, hooks, state)
+            torch._utils._rebuild_parameter,
+            (self.data, self.requires_grad, OrderedDict())
         )
 
     __torch_function__ = _disabled_torch_function_impl
