Fix memory leak during packing in tuples (#13305)

albanD · facebook-github-bot · commit f06b70a6e9b8 · 2018-10-30T08:32:26.000-07:00
Summary: Verified on python 3.6 that it fixes #13243 Pull Request resolved: #13305 Differential Revision: D12838764 Pulled By: soumith fbshipit-source-id: 206a8b22d1d05e5f156f1db1baaa82358f3eaa83
diff --git a/torch/csrc/utils/python_tuples.h b/torch/csrc/utils/python_tuples.h
@@ -11,7 +11,7 @@ inline void THPUtils_packInt64Array(PyObject *tuple, size_t size, const int64_t
     if (!i64) {
       throw python_error();
     }
-    PyTuple_SET_ITEM(tuple, i, THPUtils_packInt64(sizes[i]));
+    PyTuple_SET_ITEM(tuple, i, i64);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ inline void THPUtils_packInt64Array(PyObject *tuple, size_t size, const int64_t`
`11`	`11`	`if (!i64) {`
`12`	`12`	`throw python_error();`
`13`	`13`	`}`
`14`		`- PyTuple_SET_ITEM(tuple, i, THPUtils_packInt64(sizes[i]));`
	`14`	`+ PyTuple_SET_ITEM(tuple, i, i64);`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`