improvement

zasdfgbnm · soumith · commit e4eab0294c45 · 2018-07-05T09:35:55.000-07:00
diff --git a/aten/src/ATen/native/TensorShape.cpp b/aten/src/ATen/native/TensorShape.cpp
@@ -618,7 +618,7 @@ std::vector<Tensor> meshgrid(TensorList tensors) {
       shape[i] = tensors[i].size(0);
       break;
     default:
-      AT_ERROR("input tensor of meshgrid must be scalar or vector");
+      AT_ERROR("Expected scalar or 1D tensor in the tensor list but got: ", tensors[i]);
     }
   }
   std::vector<Tensor> grids;
diff --git a/torch/_torch_docs.py b/torch/_torch_docs.py
@@ -5839,9 +5839,9 @@ def parse_kwargs(desc):
            r"""
 meshgrid(seq) -> seq
 
-Take a sequence of :math:`N` tensors, each of which be either scalar or 1-dimensional vector,
-and create :math:`N` grids, where the :math:`i`th grid is defined by expanding the :math:`i`th
-input over dimensions defined by other inputs.
+Take a sequence of :math:`N` tensors, each of which can be either scalar or 1-dimensional
+vector, and create :math:`N` N-dimensional grids, where the :math:`i`th grid is defined by
+expanding the :math:`i`th input over dimensions defined by other inputs.
 
 Arguments:
     seq (sequence of Tensors): sequence of scalars or 1 dimensional tensors. Scalars will be

Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,7 @@ std::vector<Tensor> meshgrid(TensorList tensors) {`
`618`	`618`	`shape[i] = tensors[i].size(0);`
`619`	`619`	`break;`
`620`	`620`	`default:`
`621`		`- AT_ERROR("input tensor of meshgrid must be scalar or vector");`
	`621`	`+ AT_ERROR("Expected scalar or 1D tensor in the tensor list but got: ", tensors[i]);`
`622`	`622`	`}`
`623`	`623`	`}`
`624`	`624`	`std::vector<Tensor> grids;`