Update on "[jit] register __getitem__ builtin"

wanchaol · wanchaol · commit d8b526e1cdd2 · 2019-07-03T15:26:59.000-07:00
[jit] register __getitem__ builtin Summary: Follow up of #21990, I am switching index select operations to a standard __getitem__ builtin, rather than bunch of different builtins according to the type, such as prim::DictIndex, prim::ListIndex, etc. This will also aligned with the some other magic methods that we already use gh-metadata: pytorch pytorch 22276 gh/wanchaol/28/head
diff --git a/torch/csrc/jit/script/sugared_value.cpp b/torch/csrc/jit/script/sugared_value.cpp
@@ -275,24 +275,6 @@ Value* SimpleValue::len(const SourceRange& loc, Function& m) {
   }
 }
 
-int64_t getAdjTupleIndex(
-    const SourceRange& loc,
-    const TupleTypePtr& tuple_type,
-    int64_t input_index,
-    bool allow_out_of_bounds) {
-  // set index to be positive to simplify logic in runtime
-  int64_t adj_index = input_index;
-  int64_t tuple_len = tuple_type->elements().size();
-  if (input_index < 0) {
-    adj_index = tuple_len + input_index;
-  }
-  if (!allow_out_of_bounds && (adj_index >= tuple_len || adj_index < 0)) {
-    throw ErrorReport(loc) << "Tuple index out of range. Tuple is length "
-                           << tuple_len << " and index is " << input_index;
-  }
-  return adj_index;
-}
-
 Value* SimpleValue::getitem(const SourceRange& loc, Function& m, Value* idx) {
   Value* val = getValue();
   TypePtr val_type = val->type();
