Update on "[JIT] Add property support for ScriptModules"

Meghan Lele · Meghan Lele · commit d22e82a0fb69 · 2020-09-10T23:32:41.000-07:00
**Summary** This commit extends support for properties to include ScriptModules. **Test Plan** This commit adds a unit test that has a ScriptModule with a user-defined property. `python test/test_jit_py3.py TestScriptPy3.test_module_properties` Differential Revision: [D22880298](https://our.internmc.facebook.com/intern/diff/D22880298) [ghstack-poisoned]
diff --git a/torch/jit/_recursive.py b/torch/jit/_recursive.py
@@ -433,7 +433,7 @@ def init_fn(script_module):
         # Add the methods to the script_module directly. This ensures they will
         # be found first when `name` is looked up (as opposed to the stubs or
         # nn.Module.forward)
-        script_module.__dict__[name] = wrapped_script_method  # type: ignore
+        script_module.__dict__[name] = wrapped_script_method
 
 
     # Make module properties available on the Python ScriptModule class.
@@ -443,7 +443,7 @@ def init_fn(script_module):
         # Setter is optional, so it may not exist.
         setter_name = property_stub.def_.setter_name()
         fset = cpp_module._get_method(setter_name.name) if setter_name else None
-        script_module.__dict__[property_name] = property(property_name, fget, fset)
+        script_module.__dict__[property_name] = property(property_name, fget, fset)  # type: ignore
 
     # copy over python methods to script module if they aren't defined on the script module
     # this is currently an internal api used only on module containers
