[custom_op] better error message on no returns

zou3519 · zou3519 · commit c1c4a13c69af · 2024-07-01T14:04:41.000-07:00
I run into this a lot. I can imagine that it would look opaque to users, so made it more friendly Old error message: "ValueError: infer_schema(func): Return has unsupported type <class 'inspect._empty'>." Test Plan: - new tests ghstack-source-id: a12db3e Pull Request resolved: #129896
diff --git a/test/test_custom_ops.py b/test/test_custom_ops.py
@@ -595,6 +595,15 @@ def blah8(x, *, y=1):
         def blah9(x, *, y):
             pass
 
+    def test_infer_schema_no_return(self):
+        with self.assertRaisesRegex(
+            ValueError, "No return type annotation was provided. Please add one."
+        ):
+
+            @torch.library.custom_op("mylib::foo", mutates_args={})
+            def foo(x: torch.Tensor, y: int):
+                return x * y
+
     def test_infer_schema_supported(self):
         def a(x: Tensor) -> Tensor:
             return torch.empty([])
diff --git a/torch/_library/infer_schema.py b/torch/_library/infer_schema.py
@@ -176,6 +176,9 @@ def parse_return(annotation, error_fn):
     if annotation is None:
         return "()"
 
+    if annotation is inspect.Parameter.empty:
+        error_fn("No return type annotation was provided. Please add one.")
+
     origin = typing.get_origin(annotation)
     if origin is not tuple:
         if annotation not in SUPPORTED_RETURN_TYPES.keys():
