Fix alias annotations for dict ops (#22900)

davidriazati · facebook-github-bot · commit ba38445cfd35 · 2019-07-16T10:28:12.000-07:00
Summary: Fixes #22553 Pull Request resolved: #22900 Pulled By: driazati Differential Revision: D16277794 fbshipit-source-id: 657f18c50c9a87597ec1a7d568cc532638cfe386
diff --git a/torch/csrc/jit/ir.cpp b/torch/csrc/jit/ir.cpp
@@ -885,8 +885,6 @@ bool Node::hasSideEffects() const {
     case prim::Print:
     case prim::RaiseException:
     case prim::SetAttr:
-    case aten::clear:
-    case aten::setdefault:
     case aten::warn:
     case aten::save:
     case aten::manual_seed:
diff --git a/torch/csrc/jit/register_prim_ops.cpp b/torch/csrc/jit/register_prim_ops.cpp
@@ -2438,7 +2438,7 @@ RegisterOperators reg2({
           " key, t default_value) -> t(*)",                                   \
           dictGet<true>),                                                     \
       Operator(                                                               \
-          "aten::setdefault(Dict(" key_type ", t) self, " key_type            \
+          "aten::setdefault(Dict(" key_type ", t)(a!) self, " key_type        \
           " key, t default_value) -> t(*)",                                   \
           dictSetDefault),                                                    \
       Operator(                                                               \
