Update on "Deprecate .mT,.T,.mH,.H on 0D tensors"

lezcano · lezcano · commit ae0e89a4ea98 · 2023-01-15T19:35:15.000Z
As discussed with ngimel, this is not only not documented, but also an unnecessary edge case. See #90463 (comment) [ghstack-poisoned]
diff --git a/aten/src/ATen/native/TensorShape.cpp b/aten/src/ATen/native/TensorShape.cpp
@@ -3546,7 +3546,6 @@ Tensor numpy_T(const Tensor &self) {
   if (n == 0) {
    // Added in PyTorch 2.0
    TORCH_WARN_ONCE("Tensor.T is deprecated on 0-D tensors. This function is the identity in these cases.");
-   throw 1;
   }
   DimVector transpose_dims;
   for (int64_t i = n - 1; i >= 0; --i) {
@@ -3560,7 +3559,6 @@ Tensor matrix_H(const Tensor &self) {
   if (ndim == 0) {
    // Added in PyTorch 2.0
    TORCH_WARN_ONCE("Tensor.H is deprecated on 0-D tensors. Consider using x.conj().");
-   throw 1;
   }
   TORCH_CHECK(ndim == 2 || ndim == 0,
       "tensor.H is only supported on matrices (2-D tensors). Got ", ndim, "-D tensor.",
@@ -3589,7 +3587,6 @@ Tensor mT(const Tensor &self) {
   if (self.dim() == 0) {
    // Added in PyTorch 2.0
    TORCH_WARN_ONCE("Tensor.mT is deprecated on 0-D tensors. This function is the identity in these cases.");
-   throw 1;
   }
   return _adjoint(self, /*transpose=*/true, "mT");
 }
@@ -3598,7 +3595,6 @@ Tensor mH(const Tensor &self) {
   if (self.dim() == 0) {
     // Added in PyTorch 2.0
    TORCH_WARN_ONCE("Tensor.mH is deprecated on 0-D tensors. Consider using x.conj().");
-   throw 1;
   }
   return _adjoint(self, /*transpose=*/false, "mH");
 }
diff --git a/test/test_mps.py b/test/test_mps.py
@@ -6880,7 +6880,7 @@ def test_T(self, device="mps"):
 
     def test_transposes(self, device="mps", dtype=torch.float32):
         for op in ("T", "H", "mT", "mH", "adjoint"):
-            shapes = ((), (2, 3), (2, 3, 4)) if op[0] == "m" or op == "adjoint" else ((), (2, 3),)
+            shapes = ((2, 3), (2, 3, 4)) if op[0] == "m" or op == "adjoint" else ((2, 3),)
             for shape in shapes:
                 a = make_tensor(shape, device=device, dtype=dtype)
                 t1 = getattr(a, op)

Original file line number	Diff line number	Diff line change
`@@ -3546,7 +3546,6 @@ Tensor numpy_T(const Tensor &self) {`
`3546`	`3546`	`if (n == 0) {`
`3547`	`3547`	`// Added in PyTorch 2.0`
`3548`	`3548`	`TORCH_WARN_ONCE("Tensor.T is deprecated on 0-D tensors. This function is the identity in these cases.");`
`3549`		`- throw 1;`
`3550`	`3549`	`}`
`3551`	`3550`	`DimVector transpose_dims;`
`3552`	`3551`	`for (int64_t i = n - 1; i >= 0; --i) {`
`@@ -3560,7 +3559,6 @@ Tensor matrix_H(const Tensor &self) {`
`3560`	`3559`	`if (ndim == 0) {`
`3561`	`3560`	`// Added in PyTorch 2.0`
`3562`	`3561`	`TORCH_WARN_ONCE("Tensor.H is deprecated on 0-D tensors. Consider using x.conj().");`
`3563`		`- throw 1;`
`3564`	`3562`	`}`
`3565`	`3563`	`TORCH_CHECK(ndim == 2 \|\| ndim == 0,`
`3566`	`3564`	`"tensor.H is only supported on matrices (2-D tensors). Got ", ndim, "-D tensor.",`
`@@ -3589,7 +3587,6 @@ Tensor mT(const Tensor &self) {`
`3589`	`3587`	`if (self.dim() == 0) {`
`3590`	`3588`	`// Added in PyTorch 2.0`
`3591`	`3589`	`TORCH_WARN_ONCE("Tensor.mT is deprecated on 0-D tensors. This function is the identity in these cases.");`
`3592`		`- throw 1;`
`3593`	`3590`	`}`
`3594`	`3591`	`return _adjoint(self, /transpose=/true, "mT");`
`3595`	`3592`	`}`
`@@ -3598,7 +3595,6 @@ Tensor mH(const Tensor &self) {`
`3598`	`3595`	`if (self.dim() == 0) {`
`3599`	`3596`	`// Added in PyTorch 2.0`
`3600`	`3597`	`TORCH_WARN_ONCE("Tensor.mH is deprecated on 0-D tensors. Consider using x.conj().");`
`3601`		`- throw 1;`
`3602`	`3598`	`}`
`3603`	`3599`	`return _adjoint(self, /transpose=/false, "mH");`
`3604`	`3600`	`}`