Skip to content

Commit aceec23

Browse files
committed
Turn on non ASCII string literals serialization
This is a follow up patch to turn on this feature in order to handle breaking forward compatibility. ghstack-source-id: 3a3c5a8 Pull Request resolved: #40719
1 parent a58695f commit aceec23

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

torch/csrc/jit/serialization/python_print.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -834,11 +834,6 @@ struct PythonPrintImpl {
834834
}
835835

836836
static bool containsNonASCIIString(const IValue& val) {
837-
// TODO: This change breaks forward compatibility.
838-
// Temporarily turning off serialization (torch.save only) of non ASCII
839-
// string literals. We will turn it on a week.
840-
return false;
841-
842837
bool hasNonASCII = false;
843838
auto checkSubvalue = [&hasNonASCII](const IValue& val) {
844839
if (val.isString()) {

0 commit comments

Comments
 (0)