Fix type hint warnings for common_methods_invocations.py (#44971)

Viswesh Sankaran · facebook-github-bot · commit a4ce3f4194d2 · 2020-09-22T13:40:46.000-07:00
Summary: Fixes a subtask of #42969 Tested the following and no warnings were seen. python test/test_type_hints.py .... ---------------------------------------------------------------------- Ran 4 tests in 180.759s OK Pull Request resolved: #44971 Reviewed By: walterddr Differential Revision: D23822274 Pulled By: visweshfb fbshipit-source-id: e3485021e348ee0a8508a9d128f04bad721795ef
diff --git a/mypy.ini b/mypy.ini
@@ -62,9 +62,6 @@ ignore_errors = True
 [mypy-torch.testing._internal.hypothesis_utils.*]
 ignore_errors = True
 
-[mypy-torch.testing._internal.common_methods_invocations.*]
-ignore_errors = True
-
 [mypy-torch.testing._internal.common_nn.*]
 ignore_errors = True
 
diff --git a/torch/testing/_internal/common_methods_invocations.py b/torch/testing/_internal/common_methods_invocations.py
@@ -7,6 +7,8 @@
 from torch._six import inf, istuple
 from torch.autograd import Variable
 
+from typing import List, Tuple, Dict, Any
+
 from torch.testing import \
     (make_non_contiguous, _dispatch_dtypes,
      floating_types, floating_types_and, floating_and_complex_types,
@@ -1540,7 +1542,7 @@ def _compare_large_trilu_indices(
     (2028, 1, -1)
 ]
 
-tri_large_tests_args = [
+tri_large_tests_args: List[Tuple[int, ...]] = [
     # Large test cases below are deliberately commented out to speed up CI
     # tests and to avoid OOM error. When modifying implementations of
     # tril_indices and triu_indices, please enable these tests and make sure
@@ -1602,9 +1604,9 @@ def unpack_variables(args):
     'reshape',
     'where'  # argument order
 }
-EXCLUDE_GRADCHECK = {
+EXCLUDE_GRADCHECK: Dict[str, Any] = {
 }
-EXCLUDE_GRADGRADCHECK = {
+EXCLUDE_GRADGRADCHECK: Dict[str, Any] = {
 }
 EXCLUDE_GRADGRADCHECK_BY_TEST_NAME = {
     # *det methods uses svd in backward when matrix is not invertible. However,
