Skip to content

Commit a356276

Browse files
soumithfacebook-github-bot
authored andcommitted
add note to Contribution Guide around recently released research (#23513)
Summary: Thanks adefazio for the feedback, adding a note to the Contribution guide so that folks don't start working on code without checking with the maintainers. Pull Request resolved: #23513 Differential Revision: D16546685 Pulled By: soumith fbshipit-source-id: 1ee8ade963703c88374aedecb8c9e5ed39d7722d
1 parent 06762b4 commit a356276

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

docs/source/community/contribution_guide.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ here is the basic process.
4949
operator/optimizer?” Giving evidence for its utility, e.g., usage
5050
in peer reviewed papers, or existence in other frameworks, helps a
5151
bit when making this case.
52+
- **Adding operators / algorithms from recently-released research**
53+
is generally not accepted, unless there is overwhelming evidence that
54+
this newly published work has ground-breaking results and will eventually
55+
become a standard in the field. If you are not sure where your method falls,
56+
open an issue first before implementing a PR.
5257
- Core changes and refactors can be quite difficult to coordinate,
5358
as the pace of development on PyTorch master is quite fast.
5459
Definitely reach out about fundamental or cross-cutting changes;

0 commit comments

Comments
 (0)