Responded to comments

Chillee · Chillee · commit a1a39c1d434f · 2019-06-18T10:36:26.000-07:00
diff --git a/aten/src/ATen/core/List_inl.h b/aten/src/ATen/core/List_inl.h
@@ -180,16 +180,10 @@ void ListPtr<T>::push_back(T&& value) const {
 
 template<class T>
 void ListPtr<T>::append(ListPtr<T> b) const {
-  size_type neededSize = this->size() + b.size();
-  if (impl_->list.capacity() < neededSize) {
-    this->reserve(std::max(impl_->list.capacity() * 2, neededSize));
-  }
   if (b.use_count() == 1) {
-    std::move(b.begin(), b.end(), this->begin());
+    impl_->list.insert(impl_->list.end(), make_move_iterator(b.impl_->list.begin()), make_move_iterator(b.impl_->list.end()));
   } else {
-    for (const auto& el: b) {
-      this->push_back(el);
-    }
+    impl_->list.insert(impl_->list.end(), b.impl_->list.begin(), b.impl_->list.end());
   }
 }
 
diff --git a/torch/csrc/jit/register_prim_ops.cpp b/torch/csrc/jit/register_prim_ops.cpp
@@ -1559,7 +1559,7 @@ int listInplaceAdd(Stack& stack) {
   c10::ListPtr<T> a = c10::make_list<T>();
   c10::ListPtr<T> b = c10::make_list<T>();
   pop(stack, a, b);
-  a.append(b);
+  a.append(std::move(b));
   push(stack, std::move(a));
   return 0;
 }
diff --git a/torch/csrc/jit/script/compiler.cpp b/torch/csrc/jit/script/compiler.cpp
@@ -1634,7 +1634,6 @@ struct to_ir {
   // If it's a list of scalars, then return the corresponding list augment op
   Symbol getAugOp(const AugAssign& stmt, const TypePtr& type) {
     if (type->cast<ListType>()) { // Lists also have in-place ops.
-      std::cout<<"generating list op"<<std::endl;
       switch (stmt.aug_op()) {
         case '+':
           return aten::add_;

Original file line number	Diff line number	Diff line change
`@@ -1559,7 +1559,7 @@ int listInplaceAdd(Stack& stack) {`
`1559`	`1559`	`c10::ListPtr<T> a = c10::make_list<T>();`
`1560`	`1560`	`c10::ListPtr<T> b = c10::make_list<T>();`
`1561`	`1561`	`pop(stack, a, b);`
`1562`		`- a.append(b);`
	`1562`	`+ a.append(std::move(b));`
`1563`	`1563`	`push(stack, std::move(a));`
`1564`	`1564`	`return 0;`
`1565`	`1565`	`}`