Update on "extend torch.jit._overload to module methods"

root · root · commit 99e737098141 · 2019-08-15T15:06:40.000-07:00
Follow up to #23886, add the same overload api specified in PEP 484 to module methods to reduce the friction of adding method overloads that was brought up in #23266. The usage is: ``` @torch.jit.overload def add(self, y: int) -> int: ... @torch.jit.overload def add(self, y: float) -> float: ... def add(): ... ```
diff --git a/torch/_jit_internal.py b/torch/_jit_internal.py
@@ -278,14 +278,6 @@ def _get_fn_overloads(qual_name):
 def _clear_fn_overloads(qual_name):
     del _overloaded_fns[qual_name]
 
-# overloading registration
-# overloads get registered in this file, and compiled in torch/jit/__init__.py
-# so that they can be imported in nn/functional.py without an import cycle
-
-# qualified_name => list[overload_functions]
-
-_overloaded_fns = {}  # noqa: T484
-
 def get_class_name(method):
     current_frame = sys._current_frames()[threading.currentThread().ident]
 
