Fix infinite loop in del_post_hook (#21914)

Kutta Srinivasan · facebook-github-bot · commit 94c61d4f328b · 2019-06-18T13:43:59.000-07:00
Summary: Pull Request resolved: #21914 #21591 added a needed feature to clean up grad accumulator post hooks when the DistributedDataParallel model object is cleaned up. There's a minor typo that causes it to loop infinitely over the first element. Differential Revision: D15878884 fbshipit-source-id: b7fd0bbd51eb187579d639b1709c6f7b62b85e7a
diff --git a/torch/csrc/autograd/function.h b/torch/csrc/autograd/function.h
@@ -261,7 +261,7 @@ struct TORCH_API Function : std::enable_shared_from_this<Function> {
 
   // delete a post hook matching the key
   bool del_post_hook(const uintptr_t& key) {
-    for (auto it = post_hooks_.begin(); it != post_hooks_.end();) {
+    for (auto it = post_hooks_.begin(); it != post_hooks_.end(); ++it) {
       if (key == reinterpret_cast<std::uintptr_t>(it->get())) {
         post_hooks_.erase(it);
         return true;
