make half overflow checks consistent with other types (#7382)

ngimel · web-flow · commit 8c8918c3412a · 2018-05-08T14:40:18.000-07:00
diff --git a/aten/src/ATen/Half.cpp b/aten/src/ATen/Half.cpp
@@ -33,6 +33,10 @@ template<> AT_API int64_t convert(Half f) {
 }
 
 template<> bool overflows<Half, double>(double f) {
+  using limit = std::numeric_limits<double>;
+  if (limit::has_infinity && std::isinf(f)) {
+    return false;
+  }
   return f > 65504 || f < -65504;
 }
 template<> bool overflows<Half, int64_t>(int64_t f) {

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,10 @@ template<> AT_API int64_t convert(Half f) {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`template<> bool overflows<Half, double>(double f) {`
	`36`	`+ using limit = std::numeric_limits<double>;`
	`37`	`+ if (limit::has_infinity && std::isinf(f)) {`
	`38`	`+ return false;`
	`39`	`+ }`
`36`	`40`	`return f > 65504 \|\| f < -65504;`
`37`	`41`	`}`
`38`	`42`	`template<> bool overflows<Half, int64_t>(int64_t f) {`