throw error when grid_sample is passed unsupported mode (#8884)

li-roy · soumith · commit 85f4d2b55a09 · 2018-06-25T22:37:41.000-04:00
diff --git a/test/test_nn.py b/test/test_nn.py
@@ -4574,6 +4574,10 @@ def test_cosine_similarity(self):
         input2 = torch.randn(input_size, requires_grad=True)
         self.assertEqual(F.cosine_similarity(input1, input2, dim=1).size(), expected_size)
 
+    def test_grid_sample_unsupported_mode(self):
+        with self.assertRaisesRegex(NotImplementedError, "nn.functional.grid_sample got unsupported mode: 'garbage'"):
+            F.grid_sample(torch.tensor([]), torch.tensor([]), mode='garbage')
+
     def test_grid_sample(self):
         def test_cpu_against_cuda(N, C, H, W, padding_mode):
             def test_shape(N, C, IH, IW, H, W, padding_mode):
diff --git a/torch/nn/functional.py b/torch/nn/functional.py
@@ -1902,6 +1902,8 @@ def grid_sample(input, grid, mode='bilinear', padding_mode='zeros'):
         output (Tensor): output Tensor
 
     """
+    if mode != 'bilinear':
+        raise NotImplementedError("nn.functional.grid_sample got unsupported mode: '{}'".format(mode))
     return vision.grid_sampler(input, grid, padding_mode)
 
 
