Revert "[BE]: Update mypy to 1.10.0 (#127717)"

pytorchmergebot · pytorchmergebot · commit 84776d7597c8 · 2024-06-03T02:52:47.000Z
This reverts commit 30213ab. Reverted #127717 on behalf of https://github.com/huydhn due to I am not sure why but the failures look legit and they are showing up in trunk https://hud.pytorch.org/pytorch/pytorch/commit/30213ab0a7b27277e76ea9dd707ce629a63d91ee ([comment](#127717 (comment)))
diff --git a/.ci/docker/requirements-ci.txt b/.ci/docker/requirements-ci.txt
@@ -85,10 +85,10 @@ librosa>=0.6.2 ; python_version < "3.11"
 #Pinned versions:
 #test that import:
 
-mypy==1.10.0
+mypy==1.9.0
 # Pin MyPy version because new errors are likely to appear with each release
 #Description: linter
-#Pinned versions: 1.10.0
+#Pinned versions: 1.9.0
 #test that import: test_typing.py, test_type_hints.py
 
 networkx==2.8.8
diff --git a/.lintrunner.toml b/.lintrunner.toml
@@ -136,7 +136,7 @@ init_command = [
     'numpy==1.24.3 ; python_version == "3.8"',
     'numpy==1.26.0 ; python_version >= "3.9"',
     'expecttest==0.1.6',
-    'mypy==1.10.0',
+    'mypy==1.9.0',
     'sympy==1.11.1',
     'types-requests==2.27.25',
     'types-PyYAML==6.0.7',
diff --git a/torch/ao/quantization/fx/fuse_handler.py b/torch/ao/quantization/fx/fuse_handler.py
@@ -44,7 +44,7 @@ class DefaultFuseHandler(FuseHandler):
     def __init__(
             self,
             node: Node):
-        super().__init__(node)  # type:ignore[safe-super]
+        super().__init__(node)
 
     def fuse(self,
              load_arg: Callable,
diff --git a/torch/distributed/_composable/fsdp/fully_shard.py b/torch/distributed/_composable/fsdp/fully_shard.py
@@ -342,8 +342,4 @@ def wrapped_method(self, *args, **kwargs):
         return fsdp_state._post_forward(self, args, out)
 
     # Use `__get__` to make `wrapped_method` an instance method
-    setattr(
-        module,
-        method_name,
-        wrapped_method.__get__(module, type(module)),  # type:ignore[attr-defined]
-    )
+    setattr(module, method_name, wrapped_method.__get__(module, type(module)))
diff --git a/torch/distributions/utils.py b/torch/distributions/utils.py
@@ -117,7 +117,7 @@ class lazy_property:
 
     def __init__(self, wrapped):
         self.wrapped = wrapped
-        update_wrapper(self, wrapped)  # type:ignore[arg-type]
+        update_wrapper(self, wrapped)
 
     def __get__(self, instance, obj_type=None):
         if instance is None:
diff --git a/torch/fx/experimental/rewriter.py b/torch/fx/experimental/rewriter.py
@@ -60,7 +60,7 @@ def change_func_globals(f, globals):
                 closure=f.__closure__,
             )
             g = functools.update_wrapper(g, f)
-            g.__kwdefaults__ = copy.copy(f.__kwdefaults__)  # type:ignore[attr-defined]
+            g.__kwdefaults__ = copy.copy(f.__kwdefaults__)
             return g
         # Return the correct FunctionType object
         return change_func_globals(fn_compiled, globals=fn.__globals__)

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ def change_func_globals(f, globals):`
`60`	`60`	`closure=f.__closure__,`
`61`	`61`	`)`
`62`	`62`	`g = functools.update_wrapper(g, f)`
`63`		`- g.__kwdefaults__ = copy.copy(f.__kwdefaults__) # type:ignore[attr-defined]`
	`63`	`+ g.__kwdefaults__ = copy.copy(f.__kwdefaults__)`
`64`	`64`	`return g`
`65`	`65`	`# Return the correct FunctionType object`
`66`	`66`	`return change_func_globals(fn_compiled, globals=fn.__globals__)`