Delete redundant isContiguous check from THCUNN SpatialDilatedConvolution

ezyang · ezyang · commit 68f722716e80 · 2018-01-05T14:06:38.000-08:00
Signed-off-by: Edward Z. Yang &lt;ezyang@fb.com&gt;
diff --git a/aten/src/ATen/native/Convolution.cpp b/aten/src/ATen/native/Convolution.cpp
@@ -395,10 +395,7 @@ at::Tensor _convolution_nogroup(
     if (dim == 4) {
       if (dilated) {
         return at::thnn_conv_dilated2d(
-            // TODO: This might not be necessary in the non-CUDA case,
-            // as we only triggered a failure here with
-            // test_ConvTranspose1d_cuda.  Very unsatisfactory...
-            input, weight.contiguous(), kernel_size, bias,
+            input, weight, kernel_size, bias,
             stride, padding, dilation);
       } else {  /* dim == 4, non-dilated */
         if (params.use_nnpack(input)) {
diff --git a/aten/src/THCUNN/generic/SpatialDilatedConvolution.cu b/aten/src/THCUNN/generic/SpatialDilatedConvolution.cu
@@ -16,8 +16,6 @@ static inline void THNN_(SpatialDilatedConvolution_shapeCheck)(
 	           "kernel size should be greater than zero, but got kH: %d kW: %d", kH, kW);
   THArgCheck(dW > 0 && dH > 0, 11,
              "stride should be greater than zero, but got dH: %d dW: %d", dH, dW);
-  THArgCheck(THCTensor_(isContiguous)(state, weight), 4,
-             "weight tensor has to be contiguous");
   THArgCheck(!bias || THCTensor_(isContiguous)(state, bias), 5,
              "bias tensor has to be contiguous");
   THArgCheck(dilationW > 0 && dilationH > 0, 14,
